false offense for Style/CommentedKeyword

[chuck-john]

Expected behavior

I expect rubocop to allow literal octothorpes and interpolated strings in method arguments.

Actual behavior

An offense was generated for an interpolated string in a method argument. The offense claims this is a comment, which triggered a violation of the Style/CommentedKeyword cop.

Steps to reproduce the problem

1. Define a method with an octothorpe in a string as a default method argument.
2. Run $ rubocop
3. An offense similar to the screenshot below should get generated.

RuboCop version

0.51.0

[codebycliff]

I have another example of a false positive:

[Drenmi]

Hm. I'm guessing this cop uses a regular expression instead of checking for comments outside the AST. 😅

[backus]

Hm. I'm guessing this cop uses a regular expression instead of checking for comments outside the AST. 😅

We should add an internal affairs cop that bans this. Seems to be the source of a lot of bugs

[bbatsov]

@backus True. And I guess we don't review these things very carefully. 😆

[wurde]

Same problem here.

app/helpers/bootstrap/alert_helper.rb:49:40: C: Do not place comments on the same line as the def keyword.
    def alert_link(name = nil, path = '#', options = {}, &block)
                                       ^^^^^^^^^^^^^^^^^^^^^^^^^

[reitermarkus]

Also here:

def self.tap_paths(name, taps = Dir["#{HOMEBREW_LIBRARY}/Taps/*/*/"])

[michniewicz]

same for # inside Regexp:

foo.rb:2:20: C: Do not place comments on the same line as the def keyword.
  def foo(type = /^#{self.bar}_/)