FirstMethodArgumentLineBreak plays poorly with arrays and hashes

[Epigene]

Maybe this is intended behavior, but it seems that Layout/FirstMethodArgumentLineBreak does nothing if the first argument is a Hash or Array literal.

Additionally, I'd like the closing parameter parenthesis to be aligned consistently, but Layout/ClosingParenthesisIndentation is no help in this (perhaps I need to use a different cop?).

---

Expected behavior

Given rubocop config:

AllCops:
  DisabledByDefault: true 
  UseCache: false
  TargetRubyVersion: 2.3.4

Layout/AlignArray:
  Enabled: true

Layout/ClosingParenthesisIndentation:
  Enabled: true

Layout/FirstMethodArgumentLineBreak:
  Enabled: true

Layout/IndentationWidth:
  Enabled: true
  Width: 2
 
Layout/MultilineMethodCallBraceLayout:
  Enabled: true
  EnforcedStyle: new_line

And offending (contrived) code:

begin
  begin
    sheet.add_row([
      a[0],
      a[1],
    ])
  end
end

begin
  begin
    sheet.add_row({
      k1: :v1,
      k2: :v2
    })
  end
end

I'd expect the autofixed code to be:

begin
  begin
    sheet.add_row(
      [
        a[0],
        a[1],
      ]
    )
  end
end

begin
  begin
    sheet.add_row(
      {
        k1: :v1,
        k2: :v2
      }
    )
  end
end

Actual behavior

begin
  begin
    sheet.add_row([
      a[0],
      a[1],
    ]
                 )
  end
end

begin
  begin
    sheet.add_row({
      k1: :v1,
      k2: :v2
    }
                 )
  end
end

RuboCop version

$ rubocop -V
0.60.0 (using Parser 2.5.3.0, running on ruby 2.3.4 x86_64-darwin17)

[athornton2012]

@marcotc we came across this issue today as well! It is the exact same as @Epigene where hashes and arrays are not getting new lines in method calls. Do you think that a fix will be released soon?
Thanks!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

[AlexWayfer]

Additional example:

sheet.add_row(k1:
  v1)

[lamont-granquist]

Dunno if this would be considered a separate issue but heredocs don't seem to be considered multiline either:

foo(<<~EOF
  here
EOF
   )

[allentsai]

I was writing a feature request, but found this issue already filed. I agree with above.

After adding

Layout/FirstMethodArgumentLineBreak:
  Enabled: true

Layout/FirstHashElementLineBreak:
  Enabled: true

Layout/ClosingParenthesisIndentation:
  Enabled: true

Layout/MultilineHashBraceLayout:
  Enabled: true
  EnforcedStyle: new_line

We end up with an autocorrection as follows.
Before:

  def public_api_as_json(options = {})
    as_json({
      only: [:id, :nature, :deleted, :token],
      methods: [:definition, :description, :label, :size],
    }.merge(options))
  end

After:

  def public_api_as_json(options = {})
    as_json({
      only: [:id, :nature, :deleted, :token],
      methods: [:definition, :description, :label, :size],
    }.merge(options)
           )
  end

I would have liked to end up with

  def public_api_as_json(options = {})
    as_json({
      only: [:id, :nature, :deleted, :token],
      methods: [:definition, :description, :label, :size],
    }.merge(options))
  end

or

  def public_api_as_json(options = {})
    as_json(
      {
        only: [:id, :nature, :deleted, :token],
        methods: [:definition, :description, :label, :size],
      }.merge(options)
    )
  end

[allentsai]

The cop might be somewhat broken, rubocop does not complain about:

        with(:get_object,
             custom_audience.fb_id,
             fields: request_fields
            ).

I would expect it to return:

        with(
          :get_object,
          custom_audience.fb_id,
          fields: request_fields
        ).

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

[lamont-granquist]

still there AFAIK

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

[stale]

This issues been automatically closed due to lack of activity. Feel free to re-open it if you ever come back to it.

[lamont-granquist]

confirmed bug still exists in rubocop 1.2.0