Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rubocop-performance post install message #7042

Closed
roberts1000 opened this issue May 14, 2019 · 3 comments · Fixed by #7049
Closed

Remove rubocop-performance post install message #7042

roberts1000 opened this issue May 14, 2019 · 3 comments · Fixed by #7049
Assignees
@koic

Comments

@roberts1000
Copy link
Contributor

Can the post install message about the rubocop-performance be removed at some point? It's already documented at https://github.com/rubocop-hq/rubocop/blob/master/manual/extensions.md and that should be sufficient.

My team embeds the rubocop gem in a wrapping gem that installs rubocop-performance and configures a premade .rubocop.yml file. The post install message makes some developers think they need to take some action.
@bbatsov
Copy link
Collaborator

bbatsov commented May 14, 2019

Yeah, I agree we should remove it at this point. @koic Can you handle this?

koic added a commit to koic/rubocop that referenced this issue May 15, 2019
@koic
[Fix rubocop#7042] Remove post install message for RuboCop Performance
54b53c4 
Closes rubocop#7042.

Since a migration period to extract RuboCop Performance is over,
this PR removes post install message.
@koic koic mentioned this issue May 15, 2019
Merged
8 tasks
@koic
Copy link
Member

koic commented May 15, 2019

I agree too. I opened a PR #7049.

bbatsov pushed a commit that referenced this issue May 15, 2019
@koic @bbatsov
[Fix #7042] Remove post install message for RuboCop Performance
ed3b9c8 
Closes #7042.

Since a migration period to extract RuboCop Performance is over,
this PR removes post install message.
@roberts1000
Copy link
Contributor Author

Thanks for the fast turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koic koic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #7042] Remove post install message for RuboCop Performance koic/rubocop
3 participants
@koic @bbatsov @roberts1000