Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To check the value of "Enabled" in YAML configuration is true or false #7056

Closed
unasuke opened this issue May 18, 2019 · 2 comments
Closed

Comments

@unasuke
Copy link
Contributor

unasuke commented May 18, 2019

Is your feature request related to a problem? Please describe.

Our team occurred a problem that, unexpected cop was in effect.
The cause was the wrong config value like an "Enabled: disabled".

Describe the solution you'd like

I think it's helpful to check the value of a yaml key "Enabled".

Like this.

Screenshot from 2019-05-18 19-11-37

Describe alternatives you've considered

none.

Additional context

I already have a patch!

unasuke added a commit to unasuke/rubocop that referenced this issue Aug 14, 2019
It causes unexpected cop warnings because treats as truthy value if
passed neither true nor false in 'Enabled' key's value like
"Enabled: disable".  rubocop#7056
@stale
Copy link

stale bot commented Aug 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

@stale stale bot added the stale Issues that haven't been active in a while label Aug 16, 2019
@koic
Copy link
Member

koic commented Aug 16, 2019

This issue is addressed in #7272.

@stale stale bot removed the stale Issues that haven't been active in a while label Aug 16, 2019
bbatsov pushed a commit that referenced this issue Aug 19, 2019
It causes unexpected cop warnings because treats as truthy value if
passed neither true nor false in 'Enabled' key's value like
"Enabled: disable".  #7056
@unasuke unasuke closed this as completed Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants