Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation fails on Ubuntu 18.04 running Ruby 2.6.3 #7447

Closed
sjayanna opened this issue Oct 18, 2019 · 2 comments
Closed

Installation fails on Ubuntu 18.04 running Ruby 2.6.3 #7447

sjayanna opened this issue Oct 18, 2019 · 2 comments

Comments

@sjayanna
Copy link

The jaro_winkler gem is also failing to install and so I am not sure if the issue is with that gem or with Rubocop but wanted to report it. Rubocop installs just fine if I revert back to Ruby 2.5.3.

Building native extensions. This could take a while...
ERROR:  Error installing rubocop:
	ERROR: Failed to build gem native extension.

    current directory: /home/sjayanna/.rvm/gems/ruby-2.6.3/gems/jaro_winkler-1.5.3/ext/jaro_winkler
/home/sjayanna/.rvm/rubies/ruby-2.6.3/bin/ruby -I /home/sjayanna/.rvm/rubies/ruby-2.6.3/lib/ruby/site_ruby/2.6.0 -r ./siteconf20191018-14011-1xlq2d.rb extconf.rb
creating Makefile

current directory: /home/sjayanna/.rvm/gems/ruby-2.6.3/gems/jaro_winkler-1.5.3/ext/jaro_winkler
make "DESTDIR=" clean

current directory: /home/sjayanna/.rvm/gems/ruby-2.6.3/gems/jaro_winkler-1.5.3/ext/jaro_winkler
make "DESTDIR="
compiling adj_matrix.c
gcc: error: unrecognized command line option '-Wduplicated-cond'
gcc: error: unrecognized command line option '-Wmisleading-indentation'
gcc: error: unrecognized command line option '-Wrestrict'
gcc: error: unrecognized command line option '-Wimplicit-fallthrough=0'
Makefile:243: recipe for target 'adj_matrix.o' failed
make: *** [adj_matrix.o] Error 1

make failed, exit code 2

Gem files will remain installed in /home/sjayanna/.rvm/gems/ruby-2.6.3/gems/jaro_winkler-1.5.3 for inspection.
Results logged to /home/sjayanna/.rvm/gems/ruby-2.6.3/extensions/x86_64-linux/2.6.0/jaro_winkler-1.5.3/gem_make.out```
@koic
Copy link
Member

koic commented Oct 19, 2019

It seems that jaro_winkler gem installation failed. Could you please open the issue to jaro_winkler?
https://github.com/tonytonyjan/jaro_winkler/issues

/Cc @tonytonyjan

@sjayanna
Copy link
Author

@koic Done. tonytonyjan/jaro_winkler#31

@Drenmi Drenmi closed this as completed Oct 22, 2019
@buehmann buehmann mentioned this issue Jan 26, 2020
Closed
koic added a commit to koic/rubocop that referenced this issue Apr 12, 2020
@koic
Drop support for Ruby 2.3
aa85bcd 
### Summary

This PR drops support for Ruby 2.3.

It is discussed in rubocop#6945.
And this suggestion would mean that RuboCop 1.0 (and pre-release)
requires Ruby 2.4 or higher.

The following is a plan after this PR.
There was a build error report for a dependent jaro_winkler gem.
rubocop#5989, rubocop#6754, rubocop#7447, and rubocop#7564. And rubocop#7673 was trying to solve it.

After dropping Ruby 2.3, replace jaro_winkler with did_you_mean.
did_you_mean is written in Ruby, so the build error due to native
extensions no longer occur. That change opens as anther PR.

### Other Information

The latest did_you_mean (1.4.0) supports Ruby 2.5 or higher,
so it needs to be confirmed old versions it works with Ruby 2.4.
@koic koic mentioned this issue Apr 12, 2020
Merged
8 tasks
bbatsov pushed a commit that referenced this issue Apr 12, 2020
@koic @bbatsov
Drop support for Ruby 2.3
5873894 
### Summary

This PR drops support for Ruby 2.3.

It is discussed in #6945.
And this suggestion would mean that RuboCop 1.0 (and pre-release)
requires Ruby 2.4 or higher.

The following is a plan after this PR.
There was a build error report for a dependent jaro_winkler gem.
#5989, #6754, #7447, and #7564. And #7673 was trying to solve it.

After dropping Ruby 2.3, replace jaro_winkler with did_you_mean.
did_you_mean is written in Ruby, so the build error due to native
extensions no longer occur. That change opens as anther PR.

### Other Information

The latest did_you_mean (1.4.0) supports Ruby 2.5 or higher,
so it needs to be confirmed old versions it works with Ruby 2.4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #7564] Drop dependency on jaro_winkler gem buehmann/rubocop
3 participants
@koic @sjayanna @Drenmi