Style/RaiseArgs cop only reports the first instance encountered

[pbernays]

As the title suggests, Style/RaiseArgs only reports one instance at a time. I'm not clear on the context of compact vs exploded, nor the idea behind opposite_style_detected, but commenting out line 106 (return unless opposite_style_detected) of the cop seems to take care of business. This line was introduced after 0.89.0 and the cop works fine before that.

---

Expected behavior

Multiple instances of raising an error that instantiates an error class with a message all report the Style/RaiseArgs cop.

Actual behavior

(Edited)
Only the instances that Rubocop encounters before subsequently encountering the allowed form of raising errors are reported. All other instances are ignored.

Steps to reproduce the problem

(Edited)

rubocop_test.rb:

# frozen_string_literal: true

raise ArgumentError.new('foobar') if ENV['foobar']
raise ArgumentError, 'foobar' if ENV['foobar']

raise ArgumentError.new('foobar')

$ rubocop
Inspecting 1 file
C

Offenses:

rubocop_test.rb:3:1: C: Style/RaiseArgs: Provide an exception class and message as arguments to raise.
raise ArgumentError.new('foobar') if ENV['foobar']
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected, 1 offense auto-correctable

RuboCop version

0.91.0

[KaraAJC]

I am getting similar behavior running the Layout/SpaceInsideBlockBraces cop, where only the first encounter is reported, and I have to repeatedly run rubocop to find each following issue.

[fatkodima]

Can't reproduce.
Do you have any rubocop-related gems, like rubocop-rails, etc? Which versions do they have?

[pbernays]

Yes, we have rubocop-rails 2.8.1, rubocop-rspec 1.2.9, and rubocop-thread_safety 0.3.4. However, I ran rubocop --auto-gen-config without the plugins and a bare .rubocop.yml against the code base with four instances of raise ArgumentError.new("foobar") across two files. The generated .rubocop_todo.yml had:

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: compact, exploded
Style/RaiseArgs:
  Exclude:
    - 'config/environments/development.rb'

where I would have expected 4 offences and config/environments/test.rb to be excluded as well. Running rubocop from within config or config/environments, or passing those directories as arguments to rubocop correctly reports all 4 offences. I'll keep moving the raises around to try isolating an area of the code base that reproduces the problem without running on the whole project.

[pbernays]

I isolated the problem down to one file and edited the steps to reproduce in the initial comment.

[pbernays]

Other examples where this fails, including @KaraAJC's finding:

# frozen_string_literal: true

raise ArgumentError, 'foobar' if ENV['foobar']
raise ArgumentError.new('foobar') if ENV['foobar']
raise ArgumentError.new('foobar') if ENV['foobar']

[:foo].each { puts 3 }
[:bar].each {puts 3}
[].each {puts 3}

String.new
String.
  new
String.
  new

def foobar1(foo = nil, bar = nil)
  puts [foo, bar]
end

def foobar2(foo=nil, bar=nil)
  puts [foo, bar]
end

def foobar3(foo=nil, bar=nil)
  puts [foo, bar]
end

Also related to #8799 and #8801.

I don't know what the intent is with disabling an enforced style mid-run, but any cop that uses return unless opposite_style_detected does exactly that because of:
https://github.com/rubocop-hq/rubocop/blob/e18f297d134e7756ade1c18a81ea93e8575be7b1/lib/rubocop/cop/mixin/configurable_enforced_style.rb#L49