Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10008] Tweak offense message for Style/WordArray and Style/SymbolArray cops #10009

Conversation

koic
Copy link
Member

@koic koic commented Aug 13, 2021

Fixes #10007 and #10008.

This PR tweaks offense message for Style/WordArray and Style/SymbolArray cops. It is a clear message suggested by #10008.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…Style/SymbolArray` cops

Fixes rubocop#10007 and rubocop#10008.

This PR tweaks offense message for `Style/WordArray` and `Style/SymbolArray` cops.
It is a clear message suggested by rubocop#10008.
@bbatsov bbatsov merged commit dcc4df5 into rubocop:master Aug 16, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Aug 16, 2021

Nice improvement!

@koic koic deleted the tweak_offense_message_for_style_word_array_and_symbol_arra branch August 16, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/WordArray gives a vague message when there are spaces in the array
2 participants