Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10135] Fix Style/WordArray to exclude files in --auto-gen-config when percent style is given but brackets are required #10138

Merged
merged 1 commit into from Sep 29, 2021

Conversation

dvandersluis
Copy link
Member

When Style/WordArray is in percent style, offenses are registered for percent arrays that contain "invalid" characters, in order to replace them with a bracketed array instead. However, when this is the case, --auto-gen-config doesn't handle the file properly. This updates it to exclude the file since the result is inconsistent.

Fixes #10135.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…-gen-config` when `percent` style is given but brackets are required.
Comment on lines +148 to +150
InternalAffairs/StyleDetectedApiUse:
Exclude:
- 'lib/rubocop/cop/mixin/percent_array.rb'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InternalAffairs/StyleDetectedApiUse is registering a false positive here because it's detecting no_acceptable_style as a negative but the positive is within array_style_detected.

Interestingly, there does not seem to be any way to inline disable global offenses...

@bbatsov bbatsov merged commit 46d8867 into rubocop:master Sep 29, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Sep 29, 2021

Thanks!

@dvandersluis dvandersluis deleted the issue/10135 branch October 1, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symbol Arrays with spaces are not excluded by --auto-gen-config
2 participants