Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cimg/ruby instead of deprecated circleci/ruby images #10326

Merged

Conversation

koic
Copy link
Member

@koic koic commented Dec 28, 2021

This commit uses cimg instead of deprecated circleci images.

This image is designed to supercede the legacy CircleCI Ruby image, circleci/ruby.

https://hub.docker.com/r/cimg/ruby


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the use_cimg_instead_of_deprecated_circleci_image branch from 58300c8 to ddae2a4 Compare December 28, 2021 09:55
This commit uses cimg instead of deprecated circleci images.

> This image is designed to supercede the legacy CircleCI Ruby image, `circleci/ruby`.

https://hub.docker.com/r/cimg/ruby
@koic koic force-pushed the use_cimg_instead_of_deprecated_circleci_image branch from ddae2a4 to bfc2c2a Compare December 28, 2021 10:37
@koic koic merged commit 3ffa2bc into rubocop:master Dec 28, 2021
@koic koic deleted the use_cimg_instead_of_deprecated_circleci_image branch December 28, 2021 18:11
koic added a commit to koic/rubocop that referenced this pull request Aug 30, 2022
This is an update similar to rubocop#10326.

https://hub.docker.com/r/circleci/jruby hasn't been updated in a while.

This PR migrates the JRuby CI matrix from CircleCI to GitHub Actions to
keep up with the latest JRuby version.
koic added a commit to koic/rubocop-performance that referenced this pull request Sep 2, 2022
This update is similar to rubocop/rubocop#10326.
https://hub.docker.com/r/circleci/jruby hasn't been updated in a while.

The quickest way to get new resource is to be able to use official image.
https://hub.docker.com/_/jruby
koic added a commit to koic/rubocop-performance that referenced this pull request Sep 2, 2022
This update is similar to rubocop/rubocop#10326.
https://hub.docker.com/r/circleci/jruby hasn't been updated in a while.

The quickest way to get new resource is to be able to use official image.
https://hub.docker.com/_/jruby
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant