Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false negative for Style/HashSyntax #10371

Merged

Conversation

koic
Copy link
Member

@koic koic commented Jan 20, 2022

Follow up to #10368 (comment).

This PR fixes a false negative for Style/HashSyntax when Hash[foo: foo] or {foo: foo} is followed by a next expression.
https://bugs.ruby-lang.org/issues/18396 issue does not occur when hash syntax is enclosed in [], {}, or ().


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the fix_false_negative_for_style_hash_syntax branch from 808ced2 to 2b06e51 Compare January 20, 2022 15:41
@tycooon
Copy link

tycooon commented Jan 20, 2022

I tested this version and I get errors with new case syntax:

case foo
in a: { a: 1 } # Generates `An error occurred while Style/HashSyntax cop was inspecting` error.
  1
else
  2
end

@tycooon
Copy link

tycooon commented Jan 20, 2022

Here is the error btw:

undefined method `braces?' for s(:hash_pattern,
  s(:pair,
    s(:sym, :a),
    s(:int, 1))):RuboCop::AST::Node

        !node.parent.braces? && !use_element_of_hash_literal_as_receiver?(ancestor, node.parent) &&
                    ^^^^^^^^

@koic koic force-pushed the fix_false_negative_for_style_hash_syntax branch 3 times, most recently from a32b5b9 to a568e49 Compare January 20, 2022 16:31
@koic
Copy link
Member Author

koic commented Jan 20, 2022

Good catch! I was unaware of that case. The hash pattern matching can be ignored because its different semantic. I've updated this PR.

Follow up to rubocop#10368 (comment).

This PR fixes a false negative for `Style/HashSyntax` when
`Hash[foo: foo]` or `{foo: foo}` is followed by a next expression.

https://bugs.ruby-lang.org/issues/18396 issue does not occur when hash syntax is
enclosed in `[]`, `{}`, or `()`.
@koic koic force-pushed the fix_false_negative_for_style_hash_syntax branch from a568e49 to b1c41c5 Compare January 20, 2022 16:37
@tycooon
Copy link

tycooon commented Jan 20, 2022

Seems to work perfectly now 👍

@bbatsov bbatsov merged commit 77b5482 into rubocop:master Jan 21, 2022
@bbatsov
Copy link
Collaborator

bbatsov commented Jan 21, 2022

Looks good! Thanks!

@koic koic deleted the fix_false_negative_for_style_hash_syntax branch January 21, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants