[Fix #10421] Make Style/DefWithParentheses aware of endless method definition
#10425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
make_style_def_with_parentheses_aware_of_endless_method_definition
branch
2 times, most recently
from
9e79f9c
to
0f45607
Compare
jonas054
reviewed
Feb 20, 2022
| # # good | ||
| # def foo = do_something | ||
| # | ||
| # # good |
There was a problem hiding this comment.
Should we add an explanation here? E.g., # good (without parentheses it's a syntax error).
There was a problem hiding this comment.
Good point! I've updated it!
…method definition Fixes rubocop#10421. This PR makes `Style/DefWithParentheses` aware of endless method definition. `def foo() do_something end` will continue to allow because `def foo do_something end` is a syntax error. On the other hand, be aware that the endless method definition's parentheses can be omitted.
koic
force-pushed
the
make_style_def_with_parentheses_aware_of_endless_method_definition
branch
from
0f45607
to
b1778dd
Compare
|
Thanks! |
koic
deleted the
make_style_def_with_parentheses_aware_of_endless_method_definition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10421.
This PR makes
Style/DefWithParenthesesaware of endless method definition.def foo() do_something endwill continue to allow becausedef foo do_something endis a syntax error.On the other hand, be aware that the endless method definition's parentheses can be omitted.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.