CONTRIBUTING: Remove instruction for first-timers to edit the CHANGELOG #10431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Apparently this is no longer necessary, automation populates the username links: #10429 (comment).
|
That's still needed if you edit the changelog manually. Perhaps the right thing to do here is to just remove the suggestion for people to do this. :-) |
issyl0
commented
Feb 21, 2022
- This can be messy and cause conflicts, and there's sufficient automation in place around the individual `changelog/{type}_{some_cop}.md` entries these days. As a first-time contributor, adding the individual Markdown file with my single change was simpler than navigating the giant `CHANGELOG.md`.
|
@bbatsov Thanks; done! |
|
This looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.