[Fix #10488] Add KeepAlignedDots option for Layout/MultilineMethodCallIndentation
#10549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the current #10488 behavior is a bug. It should align the first dot, not the last dot. So, it's better to leave only this new behavior instead of the |
|
Thanks, I'll fix like that. |
…lIndentation` breaks indentation for nesting of method calls
nobuyo
force-pushed
the
add-new-option-for-multiline-method-call-indentation
branch
from
f617b79
to
c0a9b9e
Compare
|
Sorry, I had to rename branch and tried to keep PR and conversations by GitHub's branch rename function, but it closed PR automatically. I created a PR on the new branch. #10550 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10488.
The automatic correction by cop reported in the issue is syntactically correct, but it is also true that in this case we don't want it rewritten. We could switch them one by one with a comment directive, but it would be difficult if there are many, as in RSpec for example.
So I've added option to not break the dots if they are already aligned.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.