[Fix #10263] Fix aliasing problem for Enabled in Config #10797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Jul 8, 2022
|
Thanks, @koic! Updated. |
|
@jonas054 This looks good to me! Can you quash your commits into one? |
There was an aliasing problem in the `Config` class causing the `cop_options` local variable to reference the same object between different calls to `for_cop` even when the calls were to different `Config` objects with different `@hash` objects. I have not been able to figure out the root cause. Only that the phenomenon occurs, and that duplicating the cop options before setting the `Enabled` property resolves it.
jonas054
force-pushed
the
10263_fix_config_leaking
branch
from
7ae4615
to
0724f1a
Compare
|
@koic It's a single commit now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an aliasing problem in the
Configclass causing thecop_optionslocal variable to reference the same object between different calls tofor_copeven when the calls were to differentConfigobjects with different@hashobjects.I have not been able to figure out the root cause. Only that the phenomenon occurs, and that duplicating the cop options before setting the
Enabledproperty resolves it.