Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add min and max to list of false positives for Style/SymbolProc #10884

Conversation

mollerhoj
Copy link
Contributor

This PR fixes a false positive for Style/SymbolProc when using Array#min and Array#max

The cop incorrectly assumes that the two invocations below are the same, and recommends the former:

> [1,2,3].min(&:to_i)
ArgumentError: wrong number of arguments (given 1, expected 0)
> [1,2,3].min { |x| x.to_i }
=> 1

Style/SymbolProc is already marked as unsafe, but it avoids avoidable issues.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@mollerhoj mollerhoj force-pushed the add_min_and_max_to_list_of_false_positives_for_style_symbol_proc branch from 3caee0d to 13eefb4 Compare August 8, 2022 09:44
@mollerhoj mollerhoj force-pushed the add_min_and_max_to_list_of_false_positives_for_style_symbol_proc branch from 13eefb4 to 4134cb2 Compare August 8, 2022 10:06
@koic koic merged commit de683c5 into rubocop:master Aug 8, 2022
@koic
Copy link
Member

koic commented Aug 8, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants