Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10902] Fix an error for Style/RedundantRegexpEscape string with invalid byte sequence in UTF-8 #10906

Merged
merged 1 commit into from Jun 12, 2023

Conversation

ydah
Copy link
Member

@ydah ydah commented Aug 10, 2022

Fixed: #10902


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@bbatsov
Copy link
Collaborator

bbatsov commented Aug 29, 2022

Jruby 9.3.7.0 has been released. Rerun the CI.

What about this?

@ydah
Copy link
Member Author

ydah commented Aug 29, 2022

As per the comments below we need a new jruby CI environment.
#10906 (comment)

@koic
Copy link
Member

koic commented Aug 30, 2022

@ydah #10932 has been merged. Can you rebase with the latest master branch?

@ydah
Copy link
Member Author

ydah commented Aug 30, 2022

@koic Thank you! I rebase with the latest master branch and push.

@koic
Copy link
Member

koic commented Aug 30, 2022

@ydah The CI matrix has been upgraded to JRuby 9.3.7, but the test still seem to fail. Can you take a look at it?
https://github.com/rubocop/rubocop/runs/8084419128?check_suite_focus=true#step:3:20

@ydah
Copy link
Member Author

ydah commented Sep 2, 2022

It seems to work when I run the following code on jruby-9.3.7.0 in my local environment.

r = /[]/
p r
=> /[§]/
ruby -v     
jruby 9.3.7.0 (2.6.8) 2022-08-16 c79ef237e0 Java HotSpot(TM) 64-Bit Server VM 25.341-b10 on 1.8.0_341-b10 +jit [x86_64-darwin]

@bbatsov
Copy link
Collaborator

bbatsov commented Oct 21, 2022

@ydah I see this is still failing with JRuby.

@koic
Copy link
Member

koic commented Apr 24, 2023

@ydah FYI, It will need to work with the JRuby core team to get CI up and running.

@ydah
Copy link
Member Author

ydah commented Apr 24, 2023

@koic Thank you very much. I opened the following Issue.

…ring with invalid byte sequence in UTF-8

Fixed: rubocop#10902
@ydah
Copy link
Member Author

ydah commented Jun 12, 2023

@bbatsov @koic All tests now succeed with JRuby 9.4.3.0 🎉

@bbatsov bbatsov merged commit 89c4cda into rubocop:master Jun 12, 2023
28 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 12, 2023

Nice! Thanks for driving this to the finish line!

@ydah ydah deleted the fix/10902 branch June 12, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid byte sequence error when escaping utf-8 characters in a regexp character range
4 participants