Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rake prof:slow_cops to return correct results #10941

Merged
merged 1 commit into from
Aug 20, 2022

Conversation

fatkodima
Copy link
Contributor

@fatkodima fatkodima commented Aug 20, 2022

#8962 broke rake prof:slow_cops.

rake prof:slow_cops

Before

     182  (  100.0%)  Array#each
     181  (   99.5%)  Kernel#public_send
  code:

After

       9  (    4.9%)  RuboCop::Cop::Layout::RedundantLineBreak#on_send
       7  (    3.8%)  RuboCop::Cop::Layout::IndentationConsistency#on_begin
       6  (    3.3%)  RuboCop::Cop::Lint::DuplicateMethods#on_def
       6  (    3.3%)  RuboCop::Cop::MethodComplexity#on_def
       5  (    2.7%)  RuboCop::Cop::MultilineExpressionIndentation#on_send
... snip ...

cc @koic

@koic koic merged commit 23a3924 into rubocop:master Aug 20, 2022
@koic
Copy link
Member

koic commented Aug 20, 2022

Good catch! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants