Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong asterisk use in Lint/UselessRuby2Keywords document #10973

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

r7kamura
Copy link
Contributor

I found a problem with the UselessRuby2Keywords cop documentation page not rendered well.

Before

Look around the <strong> element.

<p><code>ruby2_keywords</code> should only be called on methods that accept an argument splat
(<code><strong>args</code>) but do not explicit keyword arguments (<code>k:</code> or <code>k: true</code>) or
a keyword splat (<code></strong>*kwargs</code>).</p>

After

<p><code>ruby2_keywords</code> should only be called on methods that accept an argument splat
(<code>*args</code>) but do not explicit keyword arguments (<code>k:</code> or <code>k: true</code>) or
a keyword splat (<code>**kwargs</code>).</p>

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic merged commit 65de62e into rubocop:master Aug 29, 2022
@r7kamura r7kamura deleted the feature/strong branch August 29, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants