Do not omit parentheses for calls in assignments in conditional branches #10982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsamokovarov
force-pushed
the
cond-assign-omit-parentheses
branch
from
8234e25
to
5946181
Compare
bbatsov
reviewed
Sep 1, 2022
lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb
Outdated
Show resolved
Hide resolved
bbatsov
reviewed
Sep 1, 2022
| @@ -202,6 +203,17 @@ def assigned_before?(node, target) | |||
| def inside_string_interpolation?(node) | |||
| node.ancestors.drop_while { |a| !a.begin_type? }.any?(&:dstr_type?) | |||
| end | |||
|
|
|||
| def assignment_in_condition?(node) | |||
There was a problem hiding this comment.
I think it'd be better to implement this in terms of pattern matching, as logic that goes through 2 levels of parents is both brittle and hard to understand.
There was a problem hiding this comment.
I cannot use def_node_pattern here because of the way this cop is organized. This is a module that is mixed in into Style/MethodCallWithArgsParentheses. I can invoke NodePattern by itself, but I am yet to find a good pattern that looks for a grandparent.
I did had a redundant grandparent check, though. The new implementation is simpler.
gsamokovarov
force-pushed
the
cond-assign-omit-parentheses
branch
2 times, most recently
from
501309f
to
f749701
Compare
Parentheses are required in assignments that call methods in conditional branches. Removing them is a syntax error and the `Style/MethodCallWithArgsParentheses` cop with the style of `omit_parentheses` has been doing just that. Here is an example that needs the parentheses: ```ruby if success = destroy_remote(server) delete server end ``` Removing them is a syntax error: ```ruby if success = destroy_remote server delete server end ``` Such is the case for any assignment or shorthand assignment in any Ruby conditional.
gsamokovarov
force-pushed
the
cond-assign-omit-parentheses
branch
from
f749701
to
7fd852c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parentheses are required in assignments that call methods in conditional branches. Removing them is a syntax error and the
Style/MethodCallWithArgsParenthesescop with the style ofomit_parentheseshas been doing just that during autocorrection.Here is an example that needs the parentheses but is improperly autocorrected:
Removing them, as the autocorrection does, is a syntax error:
Such is the case for any assignment or shorthand assignment in any Ruby conditional.