Add a project spec for future changelog entry #10991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.md is already mixed with and without URLs, so direct editing of CHANGELOG.md was hard to prevent formatting without URL, but the new form of adding future changelog entry to the changelog directory can force URL. Instead of reviewer pointing out, the automated test failure can inform that to reviewee.
|
Good idea! |
koic
added a commit
to rubocop/rubocop-rails
that referenced
this pull request
Sep 23, 2022
koic
added a commit
to rubocop/rubocop-performance
that referenced
this pull request
Sep 24, 2022
koic
added a commit
to rubocop/rubocop-minitest
that referenced
this pull request
Sep 25, 2022
richardstewart0213
added a commit
to richardstewart0213/performance-build-Performance-optimization-analysis-
that referenced
this pull request
Nov 4, 2022
MarttiCheng
added a commit
to MarttiCheng/Rubocop-Performance
that referenced
this pull request
Sep 28, 2023
SerhiiMisiura
added a commit
to SerhiiMisiura/Rubocop-Performance
that referenced
this pull request
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md is already mixed with and without URLs, so direct editing of CHANGELOG.md was hard to prevent formatting without URL, but the new form of adding future changelog entry to the changelog directory can force URL.
Instead of reviewer pointing out, the automated test failure can inform that to reviewee.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.