[Fix #11150] Catch redundant hyphen escape within character class #11152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Nov 11, 2022
| else | ||
| ALLOWED_OUTSIDE_CHAR_CLASS_METACHAR_ESCAPES.include?(char) | ||
| end | ||
| end | ||
|
|
||
| def char_class_begins_or_ends_with_hypen?(node, index) |
There was a problem hiding this comment.
It's not very clear what this function does, so perhaps it'd better to document it a bit.
There was a problem hiding this comment.
I didn't know how to check in a better, more descriptive way :(
I hope that with documentation it's better but I am open to any suggestions 🙏🏻
si-lens
force-pushed
the
improve_redundant_regex_escape_catching
branch
from
5771575
to
cc23ff0
Compare
Catch redundant regexp escape when the escaped hyphen is the first or the last character within the character class.
si-lens
force-pushed
the
improve_redundant_regex_escape_catching
branch
from
cc23ff0
to
c266b39
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #11150
It should catch redundant regexp escape when the hyphen is being escaped and at the same time is the first or the last character within the character class.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.