[Fix #11182] Fix an incorrect autocorrect for Style/IfUnlessModifier with Style/HashSyntax
#11185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
changed the title
Style/IfUnlessModifier with Style/HashSyntax
Prepare to solve rubocop#11182. This commit makes `Style/HashSyntax` aware of without parentheses call expr follows. It prepares to prevent `Style/HashSyntax` with `Style/IfUnlessModifier` autocorrection conflicts that resolve rubocop#11182. ## Before Previously `Style/HashSyntax` accepted the following syntax to prevent syntax errors: ```ruby foo bar value: value baz ``` This avoids the following incompatible syntax: ```ruby foo bar value: baz ``` ## After `Style/HashSyntax` registers an offense for: ```ruby foo bar value: value baz ``` And the autocorrection adds parentheses to prevent syntax errors shown in the URL: https://bugs.ruby-lang.org/issues/18396 ```ruby foo bar(value:) baz ```
…odifier` This commit fixes an incorrect autocorrect for `EnforcedShorthandSyntax: always` of `Style/HashSyntax` with `Style/IfUnlessModifier` when using Ruby 3.1.
koic
force-pushed
the
fix_an_incorrect_autocorrect_for_style_if_unless_modifier
branch
from
0df9e1f
to
7745a29
Compare
|
Thanks! |
koic
deleted the
fix_an_incorrect_autocorrect_for_style_if_unless_modifier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intentionally separates two commits to resolve #11182.
First, this resolution of #11182 requires a change of
Style/HashSyntaxbehavior.The first change makes
Style/HashSyntaxaware of without parentheses call expr follows. It prepares to preventStyle/HashSyntaxwithStyle/IfUnlessModifierautocorrection conflicts that resolve #11182.Before
Previously
Style/HashSyntaxaccepted the following syntax to prevent syntax errors:This avoids the following incompatible syntax:
After
Style/HashSyntaxregisters an offense for:And the autocorrection adds parentheses to prevent syntax errors shown in the URL:
https://bugs.ruby-lang.org/issues/18396
By assuming the above first change of
Style/HashSyntax, the next commit fixes an incorrect autocorrect forEnforcedShorthandSyntax: alwaysofStyle/HashSyntaxwithStyle/IfUnlessModifierwhen using Ruby 3.1.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.