Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple arguments on Lint/SendWithMixinArgument #11203

Merged
merged 1 commit into from
Nov 26, 2022

Conversation

r7kamura
Copy link
Contributor

@r7kamura r7kamura commented Nov 26, 2022

These mixin methods can take multiple arguments, so these patterns should also be supported in this cop.

  • Module#include
  • Module#prepend
  • Object#extend

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@r7kamura
Copy link
Contributor Author

This may be a trivial point, but I chose change as the category for the CHANGELOG entry because I figured that some existing users would expect it to work only with one argument. If another category is more appropriate, please let me know. (This may be fix if you strongly believe it should have been supported, or new if you believe it is a feature addition)

@koic koic merged commit 3e8b542 into rubocop:master Nov 26, 2022
@koic
Copy link
Member

koic commented Nov 26, 2022

Looks good to me!

@r7kamura r7kamura deleted the feature/send-with-mixin branch November 26, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants