Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Style/IfUnlessModifier when the body is a method call with hash splat #11262

Merged
merged 1 commit into from
Dec 10, 2022

Conversation

fatkodima
Copy link
Contributor

For a code like

if condition
  do_this(**options)
end

I got

     Failure/Error:
       if if_body.call_type? &&
          if_body.last_argument&.hash_type? && if_body.last_argument.pairs.last.value_omission?

     NoMethodError:
       undefined method `value_omission?' for nil:NilClass
     # ./lib/rubocop/cop/mixin/statement_modifier.rb:59:in `if_body_source'
     # ./lib/rubocop/cop/mixin/statement_modifier.rb:51:in `to_modifier_form'
     # ./lib/rubocop/cop/mixin/statement_modifier.rb:46:in `length_in_modifier_form'
     # ./lib/rubocop/cop/mixin/statement_modifier.rb:40:in `modifier_fits_on_single_line?'
     # ./lib/rubocop/cop/mixin/statement_modifier.rb:16:in `single_line_as_modifier?'

@koic koic merged commit f34af34 into rubocop:master Dec 10, 2022
@koic
Copy link
Member

koic commented Dec 10, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants