Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false negative for Style/OperatorMethodCall #11379

Conversation

koic
Copy link
Member

@koic koic commented Jan 3, 2023

This PR fixes a false negative for Style/OperatorMethodCall when using a.+ b.something.

The following is the difference depending on whether there is the dot or not.

It is the same when the argument is not enclosed in parentheses:

% ruby-parse -e "a.+ b.something"
(send
  (send nil :a) :+
  (send
    (send nil :b) :something))

% ruby-parse -e "a + b.something"
(send
  (send nil :a) :+
  (send
    (send nil :b) :something))

It is different when the argument is enclosed in parentheses.

% ruby-parse -e "a.+(b).something"
(send
  (send
    (send nil :a) :+
    (send nil :b)) :something)

% ruby-parse -e "a +(b).something"
(send nil :a
  (send
    (send
      (begin
        (send nil :b)) :something) :+@))

So the former should be warned by this cop.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes a false negative for `Style/OperatorMethodCall`
when using `a.+ b.something`.

The following is the difference depending on whether there is the dot or not.

It is the same when the argument is not enclosed in parentheses:

```console
% ruby-parse -e "a.+ b.something"
(send
  (send nil :a) :+
  (send
    (send nil :b) :something))

% ruby-parse -e "a + b.something"
(send
  (send nil :a) :+
  (send
    (send nil :b) :something))
```

It is different when the argument is enclosed in parentheses.

```console
% ruby-parse -e "a.+(b).something"
(send
  (send
    (send nil :a) :+
    (send nil :b)) :something)

% ruby-parse -e "a +(b).something"
(send nil :a
  (send
    (send
      (begin
        (send nil :b)) :something) :+@))
```

So the former should be warned by this cop.
@koic koic force-pushed the fix_a_false_negative_for_style_operator_method_call branch from d7fdeea to 0c3a67a Compare January 3, 2023 10:06
@koic koic merged commit edb8141 into rubocop:master Jan 3, 2023
@koic koic deleted the fix_a_false_negative_for_style_operator_method_call branch January 3, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant