[Fix #11405] Fix Style/WhileUntilModifier with ruby 3.1 #11406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Jan 9, 2023
CHANGELOG.md
Outdated
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## master (unreleased) | |||
|
|
|||
| ### Bug fixes | |||
|
|
|||
| * [#11405](https://github.com/rubocop/rubocop/issues/11405): Fix undefined method `range_between' for Style/WhileUntilModifier. ([@such][]) | |||
There was a problem hiding this comment.
Can you write the changelog entry with the below instead?
Added an entry (file) to the changelog folder named
{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.
koic
reviewed
Jan 9, 2023
CHANGELOG.md
Outdated
| @@ -6742,3 +6742,4 @@ | |||
| [@arika]: https://github.com/arika | |||
| [@soroktree]: https://github.com/soroktree | |||
| [@alexevanczuk]: https://github.com/alexevanczuk | |||
| [@such]: https://github.com/such | |||
There was a problem hiding this comment.
Can you remove it? Because it is automatically generated by release task.
Fix crash when while/until body last argument is a hash with value omission
|
Thanks! |
|
No problem. When do you think this can be released? |
|
Probably before the end of this week. |
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
Feb 10, 2023
Occasionally I review direct edit to the CHANGELOG.md: - rubocop#11559 (comment) - rubocop#11406 (comment) - rubocop#11395 (comment) It might be communicated a little more efficiently if listed in the CHANGELOG.md. And the triple dash for commenting out is used intentionally. https://stackoverflow.com/questions/4823468/comments-in-markdown/4829998#4829998 It affects when markdown is viewed on GitHub. This is unnecessary note for user viewing the CHANGELOG.md on GitHub. Also add changelog/.gitkeep to prevent dead link after release.
bbatsov
pushed a commit
that referenced
this pull request
Feb 11, 2023
Occasionally I review direct edit to the CHANGELOG.md: - #11559 (comment) - #11406 (comment) - #11395 (comment) It might be communicated a little more efficiently if listed in the CHANGELOG.md. And the triple dash for commenting out is used intentionally. https://stackoverflow.com/questions/4823468/comments-in-markdown/4829998#4829998 It affects when markdown is viewed on GitHub. This is unnecessary note for user viewing the CHANGELOG.md on GitHub. Also add changelog/.gitkeep to prevent dead link after release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11405
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.