Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SafeAutoCorrect: false to correct cop config #11542

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Move SafeAutoCorrect: false to correct cop config #11542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ut_assignment_indentation_and_lint_assignment_in_condition_safe_auto_correct.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* [#11542](https://github.com/rubocop/rubocop/pull/11542): Mark `Layout/AssignmentIndentation` as safe and `Lint/AssignmentInCondition` as unsafe for autocorrection. ([@eugeneius][])
5 changes: 3 additions & 2 deletions config/default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,9 +406,8 @@ Layout/AssignmentIndentation:
Checks the indentation of the first line of the
right-hand-side of a multi-line assignment.
Enabled: true
SafeAutoCorrect: false
VersionAdded: '0.49'
VersionChanged: '1.40'
VersionChanged: '<<next>>'
# By default the indentation width from `Layout/IndentationWidth` is used,
# but it can be overridden by setting this parameter.
IndentationWidth: ~
Expand Down Expand Up @@ -1573,7 +1572,9 @@ Lint/AssignmentInCondition:
Description: "Don't use assignment in conditions."
StyleGuide: '#safe-assignment-in-condition'
Enabled: true
SafeAutoCorrect: false
VersionAdded: '0.9'
VersionChanged: '<<next>>'
AllowSafeAssignment: true

Lint/BigDecimalNew:
Expand Down