Lint/RedundantHeredocDelimiterQuotes: Add spec for escapes #11543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
splattael
commented
Feb 6, 2023
| @@ -22,7 +22,8 @@ module Style | |||
| # EOS | |||
| # | |||
| # do_something(<<~'EOS') | |||
| # escaped character\. | |||
| # Preserve \ | |||
There was a problem hiding this comment.
I decided to tweak the example because I think it's more common to use quoted heredocs to retain newlines via \.
splattael
commented
Feb 6, 2023
| it 'does not register an offense when using the heredoc delimiter with escapes' do | ||
| expect_no_offenses(<<~'RUBY') | ||
| do_something(<<~'EOS') | ||
| Preserve \ |
There was a problem hiding this comment.
This tests \\ in STRING_INTERPOLATION_OR_ESCAPED_CHARACTER_PATTERN.
See https://github.com/rubocop/rubocop/pull/11528/files#r1097249283
koic
reviewed
Feb 6, 2023
spec/rubocop/cop/style/redundant_heredoc_delimiter_quotes_spec.rb
Outdated
Show resolved
Hide resolved
This commit adds a missing spec to highlight how escapes are handled. Co-authored-by: Koichi ITO <koic.ito@gmail.com>
splattael
force-pushed
the
missing-spec-style-redundant-heredoc-delimiter-quotes
branch
from
649a44b
to
c94f532
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a missing spec to highlight how escapes are handled.
Follow-up of #11528.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.