Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #11567] Fix Layout/EndAlignment false negative #11568

Merged
merged 1 commit into from
Feb 12, 2023

Conversation

j-miyake
Copy link
Contributor

@j-miyake j-miyake commented Feb 11, 2023

Fixes #11567

This PR adds the singleton class definition to the inspection targets of Layout/EndAlignment.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@j-miyake j-miyake marked this pull request as ready for review February 12, 2023 12:34
@koic koic merged commit 84ed5d9 into rubocop:master Feb 12, 2023
@koic
Copy link
Member

koic commented Feb 12, 2023

Thanks!

@j-miyake j-miyake deleted the fix_end_alignment branch February 12, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocorrect for Layout/EndAlignment does not fix alignment of end of singleton class definition
2 participants