Fix checking if token with large offset begins its line #11583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a repro test case? |
fatkodima
force-pushed
the
begins_its_line-large-offset
branch
from
069de47
to
8438e0a
Compare
|
Added a repro test case. |
koic
reviewed
Feb 17, 2023
lib/rubocop/cop/util.rb
Outdated
| @@ -93,12 +94,17 @@ def on_node(syms, sexp, excludes = [], &block) | |||
| end | |||
|
|
|||
| LINE_BEGINS_REGEX_CACHE = Hash.new do |hash, index| | |||
| hash[index] = /^\s{#{index}}\S/ | |||
| max_allowed_index = 50 | |||
There was a problem hiding this comment.
It can be a constant instead of a variable. Also, can you leave a source comment as to why 50 was chosen?
There was a problem hiding this comment.
Extracted into a constant with a comment.
fatkodima
force-pushed
the
begins_its_line-large-offset
branch
from
8438e0a
to
db3eebe
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11582.
50 is pretty reasonable number, I think. For bigger offsets we just fallback to the previous behavior.