Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #11631] Fix an incorrect autocorrect for Style/ArgumentsForwarding #11632

Merged

Conversation

koic
Copy link
Member

@koic koic commented Feb 26, 2023

Fixes #11631.

This PR fixes an incorrect autocorrect for Style/ArgumentsForwarding when using arguments forwarding for .() call.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic changed the title [Fix #11631] Fix an incorrect for Style/ArgumentsForwarding [Fix #11631] Fix an incorrect autocorrect for Style/ArgumentsForwarding Feb 26, 2023
@koic koic force-pushed the fix_an_incorrect_for_style_arguments_forwarding branch 2 times, most recently from aa470fc to 145fa10 Compare February 26, 2023 18:12
…Forwarding`

Fixes rubocop#11631.

This PR fixes an incorrect autocorrect for `Style/ArgumentsForwarding`
when using arguments forwarding for `.()` call.
@koic koic force-pushed the fix_an_incorrect_for_style_arguments_forwarding branch from 145fa10 to 2c1f329 Compare February 26, 2023 18:16
@bbatsov bbatsov merged commit 999ac27 into rubocop:master Feb 26, 2023
@bbatsov
Copy link
Collaborator

bbatsov commented Feb 26, 2023

Thanks!

@koic koic deleted the fix_an_incorrect_for_style_arguments_forwarding branch February 26, 2023 21:21
@apotonick
Copy link

Beautifu! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An error occurred while Style/ArgumentsForwarding cop
3 participants