[Fix #11685] Fix incorrect directive comment insertion when percent array violates Layout/LineLength cop
#11701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Mar 16, 2023
| RUBY | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
IMHO, mock testing is naive and should be used as little as possible. Can you replace it with cli/autocorrect_spec.rb instead?
There was a problem hiding this comment.
I moved the test to spec/rubocop/cli/disable_uncorrectable_spec.rb (it's more appropriate I think)
nobuyo
force-pushed
the
disable-uncorrectable-and-percent-array
branch
3 times, most recently
from
25540c9
to
ae532a4
Compare
koic
reviewed
Mar 16, 2023
…rcent array violates `Layout/LineLength` cop Update lib/rubocop/cop/autocorrect_logic.rb Co-authored-by: Koichi ITO <koic.ito@gmail.com>
nobuyo
force-pushed
the
disable-uncorrectable-and-percent-array
branch
from
32170ac
to
adc392a
Compare
|
Thanks! |
8 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11685.
The problem was that directive comments were inserted inside percent literals and thus had no effect.
So I've added a condition to detect percent array as well as heredoc.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.