Drop Ruby 2.6 runtime support #11791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR drops Ruby 2.6 runtime support. The next release will be the time to drop Ruby 2.6 support: - https://www.ruby-lang.org/en/downloads/branches/ - https://docs.rubocop.org/rubocop/compatibility.html#support-matrix CRuby 2.6 compatible JRuby 9.3 will be dropped and CRuby 2.7 compatible JRuby 9.4+ is required.
|
Looks good. Thanks! |
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Apr 18, 2023
Follow up rubocop/rubocop#11791.
8 tasks
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Apr 18, 2023
Follow up rubocop/rubocop#11791. This PR drops Ruby 2.6 support. And JRuby has been dropped from the CI matrix because no JRuby-specific issues have been found and prevent the following build error: ```console #!/bin/bash -eo pipefail bundle install Fetching https://github.com/rubocop/rubocop.git You need to install git to be able to use gems from git repositories. For help installing git, please refer to GitHub's tutorial at https://help.github.com/articles/set-up-git Exited with code exit status 11 CircleCI received exit code 11 ``` https://app.circleci.com/pipelines/github/rubocop/rubocop-minitest/926/workflows/68776b54-5856-4acd-a99a-f41df114634d/jobs/6034 This does not mean no support for JRuby. RuboCop Minitest will continue to support JRuby 9.4+.
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Apr 18, 2023
Follow up rubocop/rubocop#11791. This PR drops Ruby 2.6 support. And JRuby has been dropped from the CI matrix because no JRuby-specific issues have been found and prevent the following build error: ```console #!/bin/bash -eo pipefail bundle install Fetching https://github.com/rubocop/rubocop.git You need to install git to be able to use gems from git repositories. For help installing git, please refer to GitHub's tutorial at https://help.github.com/articles/set-up-git Exited with code exit status 11 CircleCI received exit code 11 ``` https://app.circleci.com/pipelines/github/rubocop/rubocop-minitest/926/workflows/68776b54-5856-4acd-a99a-f41df114634d/jobs/6034 This does not mean no support for JRuby. RuboCop Minitest will continue to support JRuby 9.4+.
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Apr 18, 2023
Follow up rubocop/rubocop#11791. This PR drops Ruby 2.6 support. And JRuby has been dropped from the CI matrix because no JRuby-specific issues have been found and prevents the following build error: ```console #!/bin/bash -eo pipefail bundle install Fetching https://github.com/rubocop/rubocop.git You need to install git to be able to use gems from git repositories. For help installing git, please refer to GitHub's tutorial at https://help.github.com/articles/set-up-git Exited with code exit status 11 CircleCI received exit code 11 ``` https://app.circleci.com/pipelines/github/rubocop/rubocop-minitest/926/workflows/68776b54-5856-4acd-a99a-f41df114634d/jobs/6034 This does not mean no support for JRuby. RuboCop Minitest will continue to support JRuby 9.4+.
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Apr 18, 2023
Follow up rubocop/rubocop#11791. This PR drops Ruby 2.6 support. And JRuby has been dropped from the CI matrix because no JRuby-specific issues have been found and prevents the following build error: ```console #!/bin/bash -eo pipefail bundle install Fetching https://github.com/rubocop/rubocop.git You need to install git to be able to use gems from git repositories. For help installing git, please refer to GitHub's tutorial at https://help.github.com/articles/set-up-git Exited with code exit status 11 CircleCI received exit code 11 ``` https://app.circleci.com/pipelines/github/rubocop/rubocop-minitest/926/workflows/68776b54-5856-4acd-a99a-f41df114634d/jobs/6034 This does not mean no support for JRuby. RuboCop Rails will continue to support JRuby 9.4+.
9 tasks
koic
added a commit
to koic/rubocop-performance
that referenced
this pull request
Apr 18, 2023
Follow up rubocop/rubocop#11791. This PR drops Ruby 2.6 support. And JRuby has been dropped from the CI matrix because no JRuby-specific issues have been found and prevents the following build error: ```console #!/bin/bash -eo pipefail bundle install Fetching https://github.com/rubocop/rubocop.git You need to install git to be able to use gems from git repositories. For help installing git, please refer to GitHub's tutorial at https://help.github.com/articles/set-up-git Exited with code exit status 11 CircleCI received exit code 11 ``` https://app.circleci.com/pipelines/github/rubocop/rubocop-minitest/926/workflows/68776b54-5856-4acd-a99a-f41df114634d/jobs/6034 This does not mean no support for JRuby. RuboCop Performance will continue to support JRuby 9.4+.
8 tasks
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Apr 18, 2023
Follow up rubocop/rubocop#11791. This PR drops Ruby 2.6 support. And JRuby has been dropped from the CI matrix because no JRuby-specific issues have been found and prevents the following build error: ```console #!/bin/bash -eo pipefail bundle install Fetching https://github.com/rubocop/rubocop.git You need to install git to be able to use gems from git repositories. For help installing git, please refer to GitHub's tutorial at https://help.github.com/articles/set-up-git Exited with code exit status 11 CircleCI received exit code 11 ``` https://app.circleci.com/pipelines/github/rubocop/rubocop-minitest/926/workflows/68776b54-5856-4acd-a99a-f41df114634d/jobs/6034 This does not mean no support for JRuby. RuboCop Rails will continue to support JRuby 9.4+.
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Apr 18, 2023
Follow up rubocop/rubocop#11791. This PR drops Ruby 2.6 support. And JRuby has been dropped from the CI matrix because no JRuby-specific issues have been found and prevents the following build error: ```console #!/bin/bash -eo pipefail bundle install Fetching https://github.com/rubocop/rubocop.git You need to install git to be able to use gems from git repositories. For help installing git, please refer to GitHub's tutorial at https://help.github.com/articles/set-up-git Exited with code exit status 11 CircleCI received exit code 11 ``` https://app.circleci.com/pipelines/github/rubocop/rubocop-minitest/926/workflows/68776b54-5856-4acd-a99a-f41df114634d/jobs/6034 This does not mean no support for JRuby. RuboCop Rails will continue to support JRuby 9.4+.
koic
added a commit
to koic/rubocop-performance
that referenced
this pull request
Apr 18, 2023
Follow up rubocop/rubocop#11791. This PR drops Ruby 2.6 support. And JRuby has been dropped from the CI matrix because no JRuby-specific issues have been found and prevents the following build error: ```console #!/bin/bash -eo pipefail bundle install Fetching https://github.com/rubocop/rubocop.git You need to install git to be able to use gems from git repositories. For help installing git, please refer to GitHub's tutorial at https://help.github.com/articles/set-up-git Exited with code exit status 11 CircleCI received exit code 11 ``` https://app.circleci.com/pipelines/github/rubocop/rubocop-minitest/926/workflows/68776b54-5856-4acd-a99a-f41df114634d/jobs/6034 This does not mean no support for JRuby. RuboCop Performance will continue to support JRuby 9.4+.
|
Note that Ruby 2.6 is still the system ruby version on the latest macos: https://apple.stackexchange.com/questions/107853/which-versions-of-mac-os-x-have-ruby-installed-by-default/107974#107974 Thus, this introduces complications for projects like Homebrew that target system ruby on macos systems. In light of this, would the |
|
Why would Homebrew need to run RuboCop on Ruby 2.6? Normally you run it for some just CI env and you specify the Ruby version that you target (e.g. 2.6). |
ydah
added a commit
to ydah/rubocop-rspec
that referenced
this pull request
Apr 24, 2023
This PR drops Ruby 2.6 runtime support. The next release will be the time to drop Ruby 2.6 support: https://www.ruby-lang.org/en/downloads/branches/ https://docs.rubocop.org/rubocop/compatibility.html#support-matrix Follow up: rubocop/rubocop#11791
ydah
added a commit
to ydah/rubocop-rspec
that referenced
this pull request
Apr 24, 2023
This PR drops Ruby 2.6 runtime support. The next release will be the time to drop Ruby 2.6 support: https://www.ruby-lang.org/en/downloads/branches/ https://docs.rubocop.org/rubocop/compatibility.html#support-matrix Follow up: rubocop/rubocop#11791
4 tasks
ydah
added a commit
to rubocop/rubocop-capybara
that referenced
this pull request
Apr 24, 2023
This PR drops Ruby 2.6 runtime support. The next release will be the time to drop Ruby 2.6 support: https://www.ruby-lang.org/en/downloads/branches/ https://docs.rubocop.org/rubocop/compatibility.html#support-matrix Follow up: rubocop/rubocop#11791
4 tasks
koic
added a commit
to koic/rubocop-ast
that referenced
this pull request
May 2, 2023
The master brach of RuboCop has been dropped Ruby 2.6 runtime support. rubocop/rubocop#11791 This PR fixes the following build error: ``` Run cd ../rubocop && bundle install --jobs 3 --retry 3 Your RubyGems version (3.0.3.1) has a bug that prevents `required_ruby_version` from working for Bundler. Any scripts that use `gem install bundler` will break as soon as Bundler drops support for your Ruby version. Please upgrade RubyGems to avoid future breakage and silence this warning by running `gem update --system 3.2.3` Fetching gem metadata from https://rubygems.org/.......... Resolving dependencies... Could not find compatible versions Because every version of rubocop depends on Ruby >= 2.7.0 and Gemfile depends on rubocop >= 0, Ruby >= 2.7.0 is required. So, because current Ruby version is = 2.6.10, version solving has failed. ``` https://github.com/rubocop/rubocop-ast/actions/runs/4857086508/jobs/8657259864
marcandre
pushed a commit
to rubocop/rubocop-ast
that referenced
this pull request
May 2, 2023
The master brach of RuboCop has been dropped Ruby 2.6 runtime support. rubocop/rubocop#11791 This PR fixes the following build error: ``` Run cd ../rubocop && bundle install --jobs 3 --retry 3 Your RubyGems version (3.0.3.1) has a bug that prevents `required_ruby_version` from working for Bundler. Any scripts that use `gem install bundler` will break as soon as Bundler drops support for your Ruby version. Please upgrade RubyGems to avoid future breakage and silence this warning by running `gem update --system 3.2.3` Fetching gem metadata from https://rubygems.org/.......... Resolving dependencies... Could not find compatible versions Because every version of rubocop depends on Ruby >= 2.7.0 and Gemfile depends on rubocop >= 0, Ruby >= 2.7.0 is required. So, because current Ruby version is = 2.6.10, version solving has failed. ``` https://github.com/rubocop/rubocop-ast/actions/runs/4857086508/jobs/8657259864
ydah
added a commit
to ydah/rubocop-rspec
that referenced
this pull request
May 4, 2023
This PR drops Ruby 2.6 runtime support. The next release will be the time to drop Ruby 2.6 support: https://www.ruby-lang.org/en/downloads/branches/ https://docs.rubocop.org/rubocop/compatibility.html#support-matrix Follow up: rubocop/rubocop#11791
8 tasks
ydah
added a commit
to ydah/rubocop-committee
that referenced
this pull request
May 18, 2023
This PR drops Ruby 2.6 runtime support. The next release will be the time to drop Ruby 2.6 support: https://www.ruby-lang.org/en/downloads/branches/ https://docs.rubocop.org/rubocop/compatibility.html#support-matrix Follow up: rubocop/rubocop#11791
6 tasks
ydah
added a commit
to ydah/rubocop-committee
that referenced
this pull request
May 18, 2023
This PR drops Ruby 2.6 runtime support. The next release will be the time to drop Ruby 2.6 support: https://www.ruby-lang.org/en/downloads/branches/ https://docs.rubocop.org/rubocop/compatibility.html#support-matrix Follow up: rubocop/rubocop#11791
koic
added a commit
that referenced
this pull request
Jun 10, 2023
Follow up #11791. RuboCop runtime supports only Ruby >= 2.7, so it removes a redundant `Symbol#to_s`.
1 task
tnir
added a commit
to tnir/rubocop
that referenced
this pull request
Jun 24, 2023
Ruby 2.6 runtime support was dropped in PR: rubocop#11791
3 tasks
tnir
reviewed
Jun 24, 2023
| @@ -0,0 +1 @@ | |||
| * [#10791](https://github.com/rubocop/rubocop/pull/10791): **(Breaking)** Drop runtime support for Ruby 2.6 and JRuby 9.3 (CRuby 2.6 compatible). ([@koic][]) | |||
bbatsov
pushed a commit
that referenced
this pull request
Jun 24, 2023
Ruby 2.6 runtime support was dropped in PR: #11791
Cute0110
added a commit
to Cute0110/Rubocop-Performance
that referenced
this pull request
Sep 28, 2023
Follow up rubocop/rubocop#11791. This PR drops Ruby 2.6 support. And JRuby has been dropped from the CI matrix because no JRuby-specific issues have been found and prevents the following build error: ```console #!/bin/bash -eo pipefail bundle install Fetching https://github.com/rubocop/rubocop.git You need to install git to be able to use gems from git repositories. For help installing git, please refer to GitHub's tutorial at https://help.github.com/articles/set-up-git Exited with code exit status 11 CircleCI received exit code 11 ``` https://app.circleci.com/pipelines/github/rubocop/rubocop-minitest/926/workflows/68776b54-5856-4acd-a99a-f41df114634d/jobs/6034 This does not mean no support for JRuby. RuboCop Performance will continue to support JRuby 9.4+.
SerhiiMisiura
added a commit
to SerhiiMisiura/Rubocop-Performance
that referenced
this pull request
Oct 5, 2023
Follow up rubocop/rubocop#11791. This PR drops Ruby 2.6 support. And JRuby has been dropped from the CI matrix because no JRuby-specific issues have been found and prevents the following build error: ```console #!/bin/bash -eo pipefail bundle install Fetching https://github.com/rubocop/rubocop.git You need to install git to be able to use gems from git repositories. For help installing git, please refer to GitHub's tutorial at https://help.github.com/articles/set-up-git Exited with code exit status 11 CircleCI received exit code 11 ``` https://app.circleci.com/pipelines/github/rubocop/rubocop-minitest/926/workflows/68776b54-5856-4acd-a99a-f41df114634d/jobs/6034 This does not mean no support for JRuby. RuboCop Performance will continue to support JRuby 9.4+.
ydah
added a commit
to rubocop/rubocop-rspec_rails
that referenced
this pull request
Mar 27, 2024
This PR drops Ruby 2.6 runtime support. The next release will be the time to drop Ruby 2.6 support: https://www.ruby-lang.org/en/downloads/branches/ https://docs.rubocop.org/rubocop/compatibility.html#support-matrix Follow up: rubocop/rubocop#11791
ydah
added a commit
to rubocop/rubocop-rspec_rails
that referenced
this pull request
Mar 27, 2024
This PR drops Ruby 2.6 runtime support. The next release will be the time to drop Ruby 2.6 support: https://www.ruby-lang.org/en/downloads/branches/ https://docs.rubocop.org/rubocop/compatibility.html#support-matrix Follow up: rubocop/rubocop#11791
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops Ruby 2.6 runtime support. The next release will be the time to drop Ruby 2.6 support:
CRuby 2.6 compatible JRuby 9.3 will be dropped and CRuby 2.7 compatible JRuby 9.4+ is required.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.