[Fix #12117] Fix Style/ArgumentsForwarding when not always forwarding a block
#12118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owst
commented
Aug 12, 2023
| @@ -280,7 +280,7 @@ def classification | |||
|
|
|||
| if can_forward_all? | |||
| :all | |||
| elsif target_ruby_version >= 3.2 | |||
There was a problem hiding this comment.
We check this condition again on line 105 (but by then we would have already rejected the false-positive this PR fixes)
koic
reviewed
Aug 12, 2023
changelog/fix_an_error_for_style_arguments_forwarding_when_not_always_forwarding_block.md
Outdated
Show resolved
Hide resolved
owst
force-pushed
the
fix_arguments_forwarding_splat_without_block
branch
from
f26551b
to
77ba017
Compare
koic
reviewed
Aug 13, 2023
koic
reviewed
Aug 13, 2023
|
Looks good to me. Can you squash your commits into one? |
…orwarding a block
owst
force-pushed
the
fix_arguments_forwarding_splat_without_block
branch
from
9f632d0
to
62a7cb9
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
TargetRubyVersion < 3.2, if some call sites forwarded the block but others didn't then the cop didn't classify the without-block call site as a forwarding call, and thus didn't notice the discrepancy between those that did forward the block and those that didn't.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.