Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #12105] Adjust target ruby gem requirement matcher and version parsing to support multiple version constraints #12127

Merged
merged 1 commit into from
Aug 17, 2023
Merged

[Fix #12105] Adjust target ruby gem requirement matcher and version parsing to support multiple version constraints #12127

merged 1 commit into from
Aug 17, 2023

Conversation

ItsEcholot
Copy link
Contributor

@ItsEcholot ItsEcholot commented Aug 17, 2023

This PR adjusts the gem_requirement matcher to support multiple version constraints if Gem::Requirement is used as a value for required_ruby_version in the gemspec. It also allows version constraints in Gem::Requirement where the string was frozen with .freeze.

More information can be found in the linked issue #12105.

Example which is now supported with this PR:

Gem::Specification.new do |s|
  s.required_ruby_version = Gem::Requirement.new(['>= 2.3.1'.freeze, '< 3.0.0'.freeze])
end

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic
Copy link
Member

koic commented Aug 17, 2023

Can you add a changelog entry?

…arsing to support multiple version constraints

[Fix #12105] Add changelog entry

[Fix #12105] Fix changelog entry
@koic koic merged commit 23dc4de into rubocop:master Aug 17, 2023
28 checks passed
@koic
Copy link
Member

koic commented Aug 17, 2023

Thanks!

@ItsEcholot ItsEcholot deleted the bugfix/required_ruby_version_gem_requirement_matching branch August 18, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants