RuboCop::Server::Cache: explicitly require 'fileutils' #12248
Conversation
…Cache The "fileutils.rb" item is dynamically added to the `$LOADED_FEATURES` due to the autoloading when calling the `RuboCop::Server::Cache.dir`. Explicit require is added to achieve idempotency when initializing the `RuboCop::ResultCache.rubocop_required_features`. This change resolves the issue where the top level cache folder was named differently during two consecutive runs of rubocop.
|
I can't say for certain without a detailed investigation, but it might be possible to write a reproduction test in https://github.com/rubocop/rubocop/blob/master/spec/rubocop/server/rubocop_server_spec.rb. |
|
@koic, I tried to add the test case here. The thing is that the line https://github.com/rubocop/rubocop/blob/master/lib/rubocop.rb#L764 prevents Also, I tried to mess around with mocks and stubs, but the intermediate result looked flaky and unmaintainable. Another option that I didn't tried is to create a separate folder with its own Gemfile and run some kind of the black-box test there. |
|
I'll merge this as is, so we can ship the bug fix with the incoming next RuboCop release. We can sort out how to test this separately. |
This PR fixes #12076.
The reproduction script: https://gist.github.com/K-S-A/1d79105baaa88adde1b6e5f6b05d641a
Please, suggest on how to proceed with the "tests" checklist item.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.