Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #12361] Fix an incorrect autocorrect for Naming/BlockForwarding #12362

Conversation

koic
Copy link
Member

@koic koic commented Nov 5, 2023

Fixes #12361.

Fix an incorrect autocorrect for Naming/BlockForwarding and Style/ArgumentsForwarding when autocorrection conflicts for anonymous arguments.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…warding`

Fixes rubocop#12361.

Fix an incorrect autocorrect for `Naming/BlockForwarding` and `Style/ArgumentsForwarding`
when autocorrection conflicts for anonymous arguments.
@bbatsov bbatsov merged commit 8579181 into rubocop:master Nov 5, 2023
28 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented Nov 5, 2023

Thanks!

@koic koic deleted the fix_an_incorrect_autocorrect_for_naming_block_fowarding branch November 5, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants