Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for Lint/LiteralAssignmentInCondition #12539

Conversation

koic
Copy link
Member

@koic koic commented Dec 14, 2023

This PR fixes the following false positive for Lint/LiteralAssignmentInCondition when a collection lireal contains non-literal elements:

$ echo 'x = 1; if test = [42, x]; end' | be rubocop --stdin test.rb --only Lint/LiteralAssignmentInCondition
Inspecting 1 file
W

Offenses:

test.rb:1:16: W: Lint/LiteralAssignmentInCondition: Don't use literal assignment = [42, x] in conditional,
should be == or non-literal operand.
x = 1; if test = [42, x]; end
               ^^^^^^^^^

1 file inspected, 1 offense detected

In cases where non-literal elements are included in the collection, no warning will be displayed.

$ ruby -we 'x = 1; if test = [42, x]; end'

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes the following false positive for `Lint/LiteralAssignmentInCondition`
when a collection lireal contains non-literal elements:

```console
$ echo 'x = 1; if test = [42, x]; end' | be rubocop --stdin test.rb --only Lint/LiteralAssignmentInCondition
Inspecting 1 file
W

Offenses:

test.rb:1:16: W: Lint/LiteralAssignmentInCondition: Don't use literal assignment = [42, x] in conditional,
should be == or non-literal operand.
x = 1; if test = [42, x]; end
               ^^^^^^^^^

1 file inspected, 1 offense detected
```

In cases where non-literal elements are included in the collection, no warning will be displayed.

```console
$ ruby -we 'x = 1; if test = [42, x]; end'
```
@koic koic force-pushed the fix_false_positives_for_lint_literal_assignment_in_condition branch from 84b0d4d to a8fdeb0 Compare December 14, 2023 10:04
@koic koic merged commit baa4a97 into rubocop:master Dec 14, 2023
28 checks passed
@koic koic deleted the fix_false_positives_for_lint_literal_assignment_in_condition branch December 14, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant