[Fix #12687] Fix a false positive for Lint/Void
#12688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rubocop#12687. This PR fixes a false positive for `Lint/Void` when `each` block with conditional expressions that has multiple statements.
bbatsov
reviewed
Feb 15, 2024
| @@ -614,6 +614,18 @@ def foo=(rhs) | |||
| RUBY | |||
| end | |||
|
|
|||
| it 'does not register `#each` block with conditional expressions that has multiple statements' do | |||
| expect_no_offenses(<<~RUBY) | |||
| enumerator_as_filter.each do |item| | |||
There was a problem hiding this comment.
Won't this be different for this different enumerators, though? Maybe some Allowed list would make more sense than just assuming that multiple expressions are OK all the time.
There was a problem hiding this comment.
Initially, I also considered Allowed list approach, but it appears that the issue was simply that the following logic for on_block was not accounted for in the implementation of on_begin.
https://github.com/rubocop/rubocop/blob/v1.60.2/lib/rubocop/cop/lint/void.rb#L86
So, I think this approach could provide a more generic solution instead of Allowed list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12687.
This PR fixes a false positive for
Lint/Voidwheneachblock with conditional expressions that has multiple statements.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.