[Fix #12695] Handle Include from inherited file in parent directory #12708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rectory When we inherit configuration from a file in a parent or ancestor directory, and that file is called `.rubocop.yml`, the paths in its Include parameters are interpreted as being relative to the file, or rather its directory. This is specific for file names starting with `.rubocop`. The problem is that file name matching that we do when searching for target files to inspect doesn't work for patterns that start with `..`. Solve the problem by matching absolute paths in these corner cases.
|
Thanks! |
dduugg
reviewed
Feb 25, 2024
| def match_path?(pattern, path) | ||
| case pattern | ||
| when String | ||
| matches = | ||
| if pattern == path | ||
| true | ||
| elsif glob?(pattern) | ||
| # File name matching doesn't really work with relative patterns the start with "..". We |
There was a problem hiding this comment.
Should be "…that start with"
There was a problem hiding this comment.
Thanks! I'll fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we inherit configuration from a file in a parent or ancestor directory, and that file is called
.rubocop.yml, the paths in its Include parameters are interpreted as being relative to the file, or rather its directory. This is specific for file names starting with.rubocop. The problem is that file name matching that we do when searching for target files to inspect doesn't work for patterns that start with... Solve the problem by matching absolute paths in these corner cases.