Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'registers no offense' instead of 'register no offense' #12779

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

ydah
Copy link
Member

@ydah ydah commented Mar 11, 2024

This PR use 'registers no offense' instead of 'register no offense'


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • [-] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@bbatsov bbatsov merged commit 134f4b0 into rubocop:master Mar 11, 2024
31 of 33 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented Mar 11, 2024

Thanks!

@ydah ydah deleted the use-registers-no-offense branch March 11, 2024 12:18
ydah added a commit to rubocop/rubocop-rspec that referenced this pull request Mar 21, 2024
This PR use 'registers no offense' instead of 'register no offense'
Follow up: rubocop/rubocop#12779
ydah added a commit to rubocop/rubocop-factory_bot that referenced this pull request Mar 21, 2024
This PR use 'registers no offense' instead of 'register no offense'
Follow up: rubocop/rubocop#12779
ydah added a commit to rubocop/rubocop-rspec_rails that referenced this pull request Mar 27, 2024
This PR use 'registers no offense' instead of 'register no offense'
Follow up: rubocop/rubocop#12779
ydah added a commit to rubocop/rubocop-rspec_rails that referenced this pull request Mar 27, 2024
This PR use 'registers no offense' instead of 'register no offense'
Follow up: rubocop/rubocop#12779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants