Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #12852] Correctly deserialize a global offense #12853

Merged
merged 1 commit into from Apr 17, 2024

Conversation

Earlopain
Copy link
Contributor

@Earlopain Earlopain commented Apr 17, 2024

Closes #12852.

A global offense goes into the cache but a range comes out. This results in errors when trying to display this range because begin/end at 0 is not valid. The global offense structure handles this, which is why only the second run will fail.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@verdammelt
Copy link

I have tested this change in the scenario reported in #12852 and it appears to correct that issue.

lib/rubocop/cached_data.rb Outdated Show resolved Hide resolved
lib/rubocop/cached_data.rb Outdated Show resolved Hide resolved
@Earlopain
Copy link
Contributor Author

Thanks for the review. Looks like CodeClimate is having some issues at the moment:

'/tmp/cc-test-reporter: line 2: `<title>504 Gateway Time-out</title>

@koic
Copy link
Member

koic commented Apr 17, 2024

I'm not sure of the cause, but something might have happened on the server side of cc-test-reporter. I've opened codeclimate/test-reporter#520. I will merge this PR. Thank you.

@koic koic merged commit d86b8d1 into rubocop:master Apr 17, 2024
26 of 32 checks passed
@Earlopain Earlopain deleted the global-offense-cache branch April 17, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash with some formatters in v1.63.2
3 participants