Move ascii_spec
, internal_investigation
to GitHub actions
#12943
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only thing left after this are the "normal" specs.
Unfortunatly GitHub doesn't support yml anchors so the matrix is duplicated. There are ways to have the matrix generated/reusable but that results in complex/unreadable actions from my experience. This ain't so bad, CircleCI didn't use/have matrix, you win some you loose some.
I'm moving the jruby job to the different jobs. I don't see why Jurby should have its own section instead of being part of the matrix. This also should speed up green CI by a bit. JRuby does take the longest and now it can execute these in parallel if there are enough available workers.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.