Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ascii_spec, internal_investigation to GitHub actions #12943

Merged

Conversation

Earlopain
Copy link
Contributor

The only thing left after this are the "normal" specs.

Unfortunatly GitHub doesn't support yml anchors so the matrix is duplicated. There are ways to have the matrix generated/reusable but that results in complex/unreadable actions from my experience. This ain't so bad, CircleCI didn't use/have matrix, you win some you loose some.


I'm moving the jruby job to the different jobs. I don't see why Jurby should have its own section instead of being part of the matrix. This also should speed up green CI by a bit. JRuby does take the longest and now it can execute these in parallel if there are enough available workers.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@bbatsov
Copy link
Collaborator

bbatsov commented May 29, 2024

I'm moving the jruby job to the different jobs. I don't see why Jurby should have its own section instead of being part of the matrix. This also should speed up green CI by a bit. JRuby does take the longest and now it can execute these in parallel if there are enough available workers.

Good idea!

Unfortunatly GitHub doesn't support yml anchors so the matrix is duplicated. There are ways to have the matrix generated/reusable but that results in complex/unreadable actions from my experience. This ain't so bad, CircleCI didn't use/have matrix, you win some you loose some.

That's fine by me.

@Earlopain Earlopain force-pushed the internal-investigation-github-actions branch 3 times, most recently from c30f226 to 607c974 Compare May 29, 2024 09:46
@Earlopain
Copy link
Contributor Author

This seems to work quite nicely actually, the windows jobs also benefit from the split. CI went from the longest job taking ~17 minutes (jruby) to ~9minutes overall

@Earlopain Earlopain marked this pull request as ready for review May 29, 2024 09:59
@bbatsov bbatsov merged commit 1cfe0b3 into rubocop:master May 29, 2024
48 checks passed
@Earlopain Earlopain deleted the internal-investigation-github-actions branch May 29, 2024 10:23
@Earlopain Earlopain mentioned this pull request May 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants