Move main tests to GitHub actions #12944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CircleCI integration will need to be removed somewhere. Not sure how that would impact existing PRs, or if that is just something that will happen once here. And the coverage upload might work after merge to master? Not sure how that works exactly, it's the correct id and works for my fork as well (with the correct id ofc). Mabye some setting to tweak? |
A job collects coverage, uploads the report as an artifact, and once all matrix entries are done a separate job will download these and use `paambaati/codeclimate-action` to pass it along to CodeClimate. This action takes care of formatting and summing the reports. In addition to that, I'm also fixing the spec filters which I forgot about in the other PRs
Earlopain
force-pushed
the
move-linux-spec-to-github-actions
branch
from
eb930ff
to
82eda43
Compare
They'll need to be rebased. I'll kill the CircleCI setup myself in a bit. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A job collects coverage, uploads the report as an artifact, and once all matrix entries are done a separate job will download these and use
paambaati/codeclimate-actionto pass it along to CodeClimate. This action takes care of formatting and summing the reports.In addition to that, I'm also fixing the spec filters which I forgot about in the other PRs
I tested the coverage upload in my fork and it works. https://codeclimate.com/repos/665735d5079a261d16c9bdef/settings/test_reporter#recent-reports, though I don't think this link is publicly accesible:
https://github.com/Earlopain/rubocop/actions/runs/9289677410/job/25564588844
This should appear for you at https://codeclimate.com/github/rubocop-hq/rubocop, click on test coverage and scroll down to recent reports.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.