-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slightly speed up CI runs #12946
Slightly speed up CI runs #12946
Conversation
GitHub actions can run 4 workers at once. There's also no need to explicitly set this variable as these are all vms. I presume that CircleCI reported a value too high
Is it possible that If that is indeed the case then you'll need to create a repository secret https://github.com/rubocop/rubocop/settings/secrets/actions/new with the correct value to reference in the job. The correct value is here: https://codeclimate.com/repos/5ee70a8d0cdfc901a1002d23/settings/test_reporter When you make it a secret, PRs from forks will not recieve this value (since otherwise the workflow can just be altered to upload secrets somewhere else), so it will only upload coverage when merging to master. This wil only for for PRs if that value is public (CodeClimate also doesn't consider it sensitive) |
There were concerns that not limiting the number of parallel processes might cause memory shortages in JRuby, but it seems there are no issues. The CI failure appears to be unrelated to this change, so I will merge it and investigate the failure separately. |
Okay, it seems I managed to delete one |
Fascinating, this does seem to have fixed the badge links in the readme. The coverage upload still fails though, is it really the same id still? |
No idea. That was the only such ID I could find in the repo's settings on CodeClimate. |
Might be a good idea to create a separate issue about the code coverage issue, so we can track all investigation in a single place. |
GitHub actions can run 4 workers at once. There's also no need to explicitly set this variable as these are all vms. I presume that CircleCI reported a value too high.
Also a good chance to see what the coverage upload is up to now.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.