[Fix #12975] Fix an error for gem_config_path
when bundler is loaded and no Gemfile exists
#12976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12975
rubocop/lib/rubocop/lockfile.rb
Lines 3 to 10 in 10d115f
With the improvement to the isolated environment, 4 tests fail. Previously they operated on the gemfile from the project folder.
The two autogen tests relied on modified env, which now is not visible anymore.
This uses
Bundler.with_unbundled_env
because bundler adds some variables that would otherwise make this hard to test.Bundler.reset!
is needed because a bunch of paths are memoized which would cause bundler to always return the Gemfile path of the rubocop folder instead of the tempfile/pwd. I added a test for that.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.