[Fix #12557] Make server mode aware of auto-restart for bundle update
#13004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
make_server_mode_aware-of_auto_restart_for_bundle_update
branch
from
065f2a9
to
b477a24
Compare
|
Does this actually consider |
…e update` Resolves rubocop#12557. Currently, the server mode only auto-restarts due to incompatible versions of RuboCop core. This PR will enable auto-restart when the SHA1 value of Gemfile.lock becomes incompatible. If Gemfile.lock is missing, it will continue to refer to the RuboCop core version as before. The advantage is that it can cover cases of version incompatibility caused by `bundle update`, which will likely cover many scenarios like those in rubocop#12557. The disadvantage is that the server mode may become slightly slower. However, it is unlikely to be slow enough for users to notice. The trade-off is considered acceptable. In the future, it might be possible to detect changes in rubocop configuration as well, but for now, I'd like to see how things go with this change.
koic
force-pushed
the
make_server_mode_aware-of_auto_restart_for_bundle_update
branch
from
b477a24
to
ed6326c
Compare
|
Ah, indeed. I've updated this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12557.
Currently, the server mode only auto-restarts due to incompatible versions of RuboCop core. This PR will enable auto-restart when the SHA1 value of Gemfile.lock becomes incompatible. If Gemfile.lock is missing, it will continue to refer to the RuboCop core version as before.
The advantage is that it can cover cases of version incompatibility caused by
bundle update, which will likely cover many scenarios like those in #12557.The disadvantage is that the server mode may become slightly slower. However, it is unlikely to be slow enough for users to notice. The trade-off is considered acceptable.
In the future, it might be possible to detect changes in rubocop configuration as well, but for now, I'd like to see how things go with this change.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.