Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #12471] Fix false negatives for Style/ZeroLengthPredicate #13009

Merged

Conversation

koic
Copy link
Member

@koic koic commented Jun 21, 2024

Fixes #12471.

This PR fixes false negatives for Style/ZeroLengthPredicate when using safe navigation operator.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Fixes rubocop#12471.

This PR fixes false negatives for `Style/ZeroLengthPredicate`
when using safe navigation operator.
@koic koic merged commit 0a223fb into rubocop:master Jun 22, 2024
22 checks passed
@koic koic deleted the fix_false_negatives_for_style_zero_length_predicate branch June 22, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Style/ZeroLengthPredicate aware of safe navigation operator
1 participant