Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug when Etc.login is nil #2406

Closed
wants to merge 1 commit into from
Closed

fix bug when Etc.login is nil #2406

wants to merge 1 commit into from

Conversation

masarakki
Copy link
Contributor

Etc.login reads $USER env, but some container base CI run as root user,
so Etc.login returns nil, and File.join('/tmp', nil) will fail.

@alexdowad
Copy link
Contributor

👍

@jonas054 jonas054 mentioned this pull request Nov 9, 2015
Closed
@jujugrrr jujugrrr mentioned this pull request Nov 9, 2015
Merged
@bbatsov
Copy link
Collaborator

bbatsov commented Nov 9, 2015

The commit message should be capitalised and a changelog entry should be added. A test case would be nice as well. :-)

@masarakki
Copy link
Contributor Author

I think #2408 is better than me.

@bbatsov
Copy link
Collaborator

bbatsov commented Nov 9, 2015

OK, closing this one.

@bbatsov bbatsov closed this Nov 9, 2015
@masarakki masarakki deleted the fix-when-login-is-nil branch November 10, 2015 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@masarakki @alexdowad @bbatsov