Fixin the bugs like that #3182
Merged
Fixin the bugs like that #3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdowad
force-pushed
the
fixin_the_bugs_like_that
branch
from
0089380
to
36e149d
Compare
alexdowad
force-pushed
the
fixin_the_bugs_like_that
branch
4 times, most recently
from
93a056c
to
69d3da2
Compare
|
The new code generates some RuboCop offenses. |
|
Yep, I'll fix it up soon. No time right now, sorry. |
|
Take your time. |
|
👍 All changes look good to me. |
|
Thanks for review, @jonas054. I'll see if I can fix up those last remaining style problems tonight. |
…ine calls (Doh!)
...As requested by Brewster. I personally also prefer this style on my own projects.
…eters It was supported anyways, through the AutocorrectAlign mixin, but not explicitly allowed as a parameter.
alexdowad
force-pushed
the
fixin_the_bugs_like_that
branch
from
69d3da2
to
fa93b31
Compare
|
Should be good now. Let's just make sure the CI build passes. |
|
👍 |
|
Thanks @bbatsov. Now there are only 107 open issues... gulp... |
|
Next week I might get to squashing a few of those myself. Too much work, too little time for anything else... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't been around for a while, and come back to discover 122 open issues have accumulated. C'mon, guys, try to fix bugs once and a while rather than just adding, adding, and adding some more, OK?